[PATCH] D81667: [FileCheck] Add precision to format specifier
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 20 00:14:18 PDT 2020
jhenderson added a comment.
I think this is basically ready now, barring my example comment.
================
Comment at: llvm/docs/CommandGuide/FileCheck.rst:754-757
+ ; CHECK: mov r[[#REG:]], 0x[[#%.8X,ADDR:]]
-would match ``mov r5, 0xF0F0`` and set ``REG`` to the value ``5`` and ``IMM``
-to the value ``0xF0F0``.
+would match ``mov r5, 0xF0F0FEFE`` and set ``REG`` to the value ``5`` and
+``ADDR`` to the value ``0xF0F0FEFE``.
----------------
If this example is meant to demonstrate the precision as well as conversion, it probably makes sense to say something like "but would not match `mov r5, 0x00F0F0FEFE`" and/or change the example to `mov r5, 0x0000F0F0`, so that it shows the precision behaviour.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81667/new/
https://reviews.llvm.org/D81667
More information about the llvm-commits
mailing list