[lld] ac46bc3 - [ELF][test] Fix some llvm-objdump RUN lines which don't actually test anything

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 22:49:15 PDT 2020


Author: Fangrui Song
Date: 2020-08-19T22:49:04-07:00
New Revision: ac46bc35e98d922f1b05b451341f03dcaccd1527

URL: https://github.com/llvm/llvm-project/commit/ac46bc35e98d922f1b05b451341f03dcaccd1527
DIFF: https://github.com/llvm/llvm-project/commit/ac46bc35e98d922f1b05b451341f03dcaccd1527.diff

LOG: [ELF][test] Fix some llvm-objdump RUN lines which don't actually test anything

Added: 
    

Modified: 
    lld/test/ELF/arm-ldrlit.s
    lld/test/ELF/arm-thumb-interwork-ifunc.s
    lld/test/ELF/arm-thumb2-adr.s

Removed: 
    


################################################################################
diff  --git a/lld/test/ELF/arm-ldrlit.s b/lld/test/ELF/arm-ldrlit.s
index a466b0a8e1d1..b6ee2d8e9da0 100644
--- a/lld/test/ELF/arm-ldrlit.s
+++ b/lld/test/ELF/arm-ldrlit.s
@@ -1,6 +1,5 @@
 // REQUIRES: arm
 // RUN: llvm-mc --triple=armv7a-none-eabi --arm-add-build-attributes -filetype=obj -o %t.o %s
-// RUN: llvm-objdump -d -r --triple=armv7a-none-eabi %t.o
 // RUN: echo "SECTIONS { \
 // RUN:                 .rodata.low 0x8012  : { *(.rodata.low) } \
 // RUN:                 .text.low   0x8f00  : { *(.text.low) } \

diff  --git a/lld/test/ELF/arm-thumb-interwork-ifunc.s b/lld/test/ELF/arm-thumb-interwork-ifunc.s
index 319737a08aad..947bc2dd7786 100644
--- a/lld/test/ELF/arm-thumb-interwork-ifunc.s
+++ b/lld/test/ELF/arm-thumb-interwork-ifunc.s
@@ -1,7 +1,7 @@
 // REQUIRES: arm
 // RUN: llvm-mc --triple=armv7a-linux-gnueabihf -arm-add-build-attributes -filetype=obj -o %t.o %s
 // RUN: ld.lld %t.o -o %t
-// RUN: llvm-objdump --triple=armv7a-none-linux-gnueabi -d --no-show-raw-insn %t
+// RUN: llvm-objdump --triple=armv7a-none-linux-gnueabi -d --no-show-raw-insn %t | FileCheck %s
 
 /// Non-preemptible ifuncs are called via a PLT entry which is always Arm
 /// state, expect the ARM callers to go direct to the PLT entry, Thumb
@@ -30,23 +30,23 @@ thumb_caller:
  b.w foo
  bl foo
 
-// CHECK: 00012004 _start:
-// CHECK-NEXT: b       #36
-// CHECK-NEXT: bl      #32
+// CHECK:      00021004 <_start>:
+// CHECK-NEXT: b       #36 <$a>
+// CHECK-NEXT: bl      #32 <$a>
 
-// CHECK: 0001200c thumb_caller:
+// CHECK:      0002100c <thumb_caller>:
 // CHECK-NEXT: b.w     #8
 // CHECK-NEXT: b.w     #4
 // CHECK-NEXT: blx     #24
 
-// CHECK: 00012018 __Thumbv7ABSLongThunk_foo:
-// CHECK-NEXT: movw    r12, #8240
-// CHECK-NEXT: movt    r12, #1
+// CHECK:      00021018 <__Thumbv7ABSLongThunk_foo>:
+// CHECK-NEXT: movw    r12, #4144
+// CHECK-NEXT: movt    r12, #2
 // CHECK-NEXT: bx      r12
 
 // CHECK: Disassembly of section .iplt:
 
-// CHECK: 00012030 $a:
+// CHECK:      00021030 <$a>:
 // CHECK-NEXT: add     r12, pc, #0, #12
-// CHECK-NEXT: add     r12, r12, #4096
+// CHECK-NEXT: add     r12, r12, #16, #20
 // CHECK-NEXT: ldr     pc, [r12, #8]!

diff  --git a/lld/test/ELF/arm-thumb2-adr.s b/lld/test/ELF/arm-thumb2-adr.s
index a6895bc878b6..c0c7cfcc3fd2 100644
--- a/lld/test/ELF/arm-thumb2-adr.s
+++ b/lld/test/ELF/arm-thumb2-adr.s
@@ -10,7 +10,6 @@
 // RUN:               } " > %t.script
 // RUN: ld.lld --script %t.script %t.o -o %t
 // RUN: llvm-readobj --symbols %t | FileCheck %s --check-prefix=SYMS
-// RUN: llvm-objdump -d --triple=thumbv7m-none-eabi %t
 // RUN: llvm-objdump -d --no-show-raw-insn --triple=thumbv7m-none-eabi %t | FileCheck %s
 
 /// Test the various legal cases for the R_ARM_THM_ALU_PREL_11_0 relocation


        


More information about the llvm-commits mailing list