[PATCH] D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops

[Whitney Tsang via Phabricator via llvm-commits]

Whitney added a comment.

In D86133#2226251 <https://reviews.llvm.org/D86133#2226251>, @TaWeiTu wrote:

> Hi @Whitney, @fhahn, thanks for your review and comment!
> Please let me know if there's any other problem with the patch.
> Also, if the patch is ready to land, is it possible for you to commit it instead (I believe I don't have the commit access)?

One minor comment, then LGTM. Let's see what Florian thinks.

Instruction to obtain commit access:
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

> Prior to obtaining commit access, it is common practice to request that someone with commit access commits on your behalf. When doing so, please provide the name and email address you would like to use in the Author property of the commit.

`--author="Ta-Wei Tu <tu.da.wei at gmail.com>"` Good?



================
Comment at: llvm/lib/Analysis/LoopNestAnalysis.cpp:245
+           all_of(BB.phis(), [&](const PHINode &PN) {
+             return all_of(PN.blocks(), [&](const BasicBlock *Source) {
+               return Source == InnerLoopExit || Source == OuterLoopHeader;
----------------
Usually blocks of PHINodes are named IncomingBlock


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86133/new/

https://reviews.llvm.org/D86133