[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 19 15:43:27 PDT 2020
MaskRay added a comment.
Mostly looks good. Thanks for working on it!
================
Comment at: lld/Common/ErrorHandler.cpp:51
+ if (errorHandler().disableOutput) {
+ static raw_null_ostream discard;
+ return discard;
----------------
llvm::nulls()
================
Comment at: lld/Common/ErrorHandler.cpp:167
void ErrorHandler::log(const Twine &msg) {
if (!verbose)
return;
----------------
The two conditions can be merged
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70378/new/
https://reviews.llvm.org/D70378
More information about the llvm-commits
mailing list