[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

[Alexandre Ganea via Phabricator via llvm-commits]

aganea updated this revision to Diff 286665.
aganea marked 9 inline comments as done.
aganea added a subscriber: tentzen.
aganea added a comment.
Herald added subscribers: mstorsjo, arichardson.

As suggested,

- Set LLD_IN_TEST=2 (still enabled for COFF only)
- Remove stdout & stderr for all iterations but the last one.

Also:

- Use CrashRecoveryContext to handle crashes or abort, and allow re-entrance.
- Ensure the cleanup is always done in case of a crash or abort.
- Disable ELF/invalid-cie-reference.s test because it requires unwinding of SEH to work correctly on Windows, and that doesn't work with previous (actual?) versions of Clang (I imagine @tentzen work will fix that)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70378/new/

https://reviews.llvm.org/D70378

Files:
  lld/COFF/Driver.cpp
  lld/COFF/Writer.cpp
  lld/COFF/Writer.h
  lld/Common/ErrorHandler.cpp
  lld/ELF/Driver.cpp
  lld/MachO/Driver.cpp
  lld/include/lld/Common/ErrorHandler.h
  lld/lib/Driver/DarwinLdDriver.cpp
  lld/test/COFF/dll.test
  lld/test/COFF/guardcf-lto.ll
  lld/test/COFF/lit.local.cfg
  lld/test/ELF/invalid-cie-reference.s
  lld/tools/lld/lld.cpp
  lld/wasm/Driver.cpp
  llvm/include/llvm/Support/CrashRecoveryContext.h
  llvm/lib/Support/CrashRecoveryContext.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70378.286665.patch
Type: text/x-patch
Size: 16975 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200819/cb14be04/attachment.bin>