[PATCH] D85989: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer.

Wed Aug 19 12:45:29 PDT 2020

RKSimon added inline comments.

================
Comment at: llvm/lib/Target/X86/X86.td:723
+                                                  FeatureRDPID,
+                                                  FeatureFSRM];
   list<SubtargetFeature> ICLTuning = CNLTuning;
----------------
yamauchi wrote:
> craig.topper wrote:
> > yamauchi wrote:
> > > RKSimon wrote:
> > > > Why has this been added to Features and not Tuning?
> > > Following FeatureERMSB which is in HSWAdditionalFeatures.
> > Both this and ERMSB have CPUID bits so its not microarchitectural.
> > 
> > ERMSB should probably be on IVB where it was introduced but nobody profiled it when the feature was added to llvm.
> So it's good to be here in Features?
Yes Features is fine - sorry for the confusion.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85989/new/

https://reviews.llvm.org/D85989