[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D85384#2226866 <https://reviews.llvm.org/D85384#2226866>, @craig.topper wrote:

> In D85384#2226842 <https://reviews.llvm.org/D85384#2226842>, @aeubanks wrote:
>
>> This doesn't work with -mtune=generic (https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html), can gcc compatibility be added?
>>
>> (https://crbug.com/1119448)
>>
>>   $ cat /tmp/a.c
>>   int main(){}
>>   $ ./build/bin/clang /tmp/a.c -o /dev/null -mtune=generic
>>   error: unknown target CPU 'generic'
>>   note: valid target CPU values are: nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512, skx, cascadelake, cooperlake, cannonlake, icelake-client, icelake-server, tigerlake, knl, knm, k8, athlon64, athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, x86-64
>
> I was planning to do work supporting that as one of my next patches. But didn't think about the fact that people would already doing it since the option was being ignored. I'll put in a quick fix.

Thanks!
There may be codebases trying to compile under both gcc and clang. Or remnants from gcc days?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85384/new/

https://reviews.llvm.org/D85384