[PATCH] D85989: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86.td:723
+                                                  FeatureRDPID,
+                                                  FeatureFSRM];
   list<SubtargetFeature> ICLTuning = CNLTuning;
----------------
yamauchi wrote:
> RKSimon wrote:
> > Why has this been added to Features and not Tuning?
> Following FeatureERMSB which is in HSWAdditionalFeatures.
Both this and ERMSB have CPUID bits so its not microarchitectural.

ERMSB should probably be on IVB where it was introduced but nobody profiled it when the feature was added to llvm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85989/new/

https://reviews.llvm.org/D85989