[PATCH] D86232: [NFC][OpenMP] Update description of OMPGridValues enums

Wed Aug 19 11:31:32 PDT 2020

saiislam added a comment.

In D86232#2226668 <https://reviews.llvm.org/D86232#2226668>, @JonChesterfield wrote:

> This can't be used in the libomptarget plugins or in the deviceRTL, as both are required to compile without the llvm sources available.
>
> Current preferences appears to be to copy and paste the numbers between the two files. At the least, we should have a test outside of llvm & openmp trees that verifies the numbers are the same in each.
>
> @jdoerfert can you remember who was strongly against #include between openmp and llvm? I'm failing to find the discussion, and the mail "Sharing enums between llvm and openmp" didn't reach a conclusion

What about if we put these gridvalues in OMPKinds.def (or OMP.td)?
Ultimately we need a common place to share content with clang, RTLs, and plugins.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86232/new/

https://reviews.llvm.org/D86232