[PATCH] D86167: [opt][NewPM] Add basic-aa in legacy PM compatibility mode

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added a comment.

> This decreases the number of check-llvm failures under NPM from 913 to 752.

This is great!



================
Comment at: llvm/tools/opt/NewPMDriver.cpp:351
+  // For compatibility with legacy pass manager.
+  // basic-aa was always available in the legacy pass manager,
+  // unless -disable-basic-aa was specified.
----------------
I think it is helpful to be specific here, saying something like "AAResultsWrapperPass` by default provide basic-aa in legacy PM."

Could we combine this code with the `if (!AAPipeline.empty())` code above? If the AAPipeline is empty, we could make it "basic-aa".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86167/new/

https://reviews.llvm.org/D86167