[PATCH] D86150: [NFC][DebugInfo] Create InstructionOrdering helper class (1/4)

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando marked 2 inline comments as done.
Orlando added a comment.

Thanks for the review! I'll land the patch alongside the others in the stack when they're good to go.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:92
+  unsigned Position = 0;
+  for (const MachineBasicBlock &MBB : MF) {
+    for (const MachineInstr &MI : MBB)
----------------
aprantl wrote:
> unnecessary {
Following the recent llvm-dev discussion on braces I got the impression that the preference was to use braces if the body doesn't sit on a single line. But looking closer, it doesn't look like a consensus was reached and AFAICT CodingStandards.rst wasn't updated either.

I'll remove them before landing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86150/new/

https://reviews.llvm.org/D86150