[PATCH] D82496: [amdgpu] Add codegen support for HIP dynamic shared memory.

[Michael Liao via Phabricator via llvm-commits]

hliao marked an inline comment as done.
hliao added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MIRYamlMapping.h:168-171
+    if (getAsUnsignedInteger(Scalar, 10, N))
+      return "invalid number";
+    if (!isPowerOf2_64(N))
+      return "must be a power of two";
----------------
arsenm wrote:
> hliao wrote:
> > arsenm wrote:
> > > Should add parser tests for these cases
> > llvm/test/CodeGen/MIR/AMDGPU/machine-function-info-no-ir.mir covers that.
> It doesn't cover the error cases
Add an invalid case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82496/new/

https://reviews.llvm.org/D82496