[PATCH] D86200: [GlobalISel] Add setting of pointer flags to ArgInfo

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 08:50:37 PDT 2020


arsenm added a comment.

In D86200#2226337 <https://reviews.llvm.org/D86200#2226337>, @ehjogab wrote:

> In D86200#2226077 <https://reviews.llvm.org/D86200#2226077>, @arsenm wrote:
>
>> I'm curious why you need this. These fields are mostly a hack for SelectionDAG?
>
> In our target argument pointers are converted into MVT::iPTRs, but in light of your comment that might be a bug in our backend. Could you comment on how, and if, MVT::iPTR are suppose to be used in GlobalISel, or are they only intended for SelectionISel?

Ideally MVT wouldn't be used at all, and we're just using the existing SelectionDAG calling convention lowering with its ties to MVT as a crutch. LLT naturally preserves that the value is a pointer with address space and size


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86200/new/

https://reviews.llvm.org/D86200



More information about the llvm-commits mailing list