[PATCH] D82496: [amdgpu] Add codegen support for HIP dynamic shared memory.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MIRYamlMapping.h:168-171
+    if (getAsUnsignedInteger(Scalar, 10, N))
+      return "invalid number";
+    if (!isPowerOf2_64(N))
+      return "must be a power of two";
----------------
Should add parser tests for these cases


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMachineFunction.cpp:59
+  // memory.
+  LDSSize = alignTo(StaticLDSSize, DynLDSAlign);
 
----------------
This is an independent field and should not be changed here


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMachineFunction.h:99
+      return;
+    LDSSize = alignTo(StaticLDSSize, A);
+    DynLDSAlign = A;
----------------
This should still not be modifying LDSSize. This is still missing an independent query to give the static + rounded size


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82496/new/

https://reviews.llvm.org/D82496