[PATCH] D86222: Fix PR46880: Fail CHECK-NOT with undefined variable

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 08:48:30 PDT 2020


thopre created this revision.
thopre added reviewers: jdenny, jhenderson, probinson, grimar, arichardson.
thopre added a project: LLVM.
Herald added a subscriber: hiraditya.
thopre requested review of this revision.

Currently a CHECK-NOT directive succeeds whenever the corresponding
match fails. However match can fail due to an error rather than a lack
of match, for instance if a variable is undefined.

This commit makes match error a failure for CHECK-NOT and changes
PrintNoMatch to print all CHECK-NOT failure in a CHECK-NOT block rather
than just the first one.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86222

Files:
  llvm/include/llvm/Support/FileCheck.h
  llvm/lib/Support/FileCheck.cpp
  llvm/test/FileCheck/dump-input-annotations.txt
  llvm/test/FileCheck/numeric-expression.txt
  llvm/test/FileCheck/var-scope.txt
  llvm/utils/FileCheck/FileCheck.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86222.286573.patch
Type: text/x-patch
Size: 12294 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200819/a4b034cd/attachment.bin>


More information about the llvm-commits mailing list