[PATCH] D85771: [DebugInstrRef][8/9] Convert DBG_INSTR_REFs into variable locations

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:923
   void defVar(const MachineInstr &MI, const MachineOperand &MO) {
     // XXX skipping overlapping fragments for now.
+    // Only DBG_VALUEs can define constant-valued variables.
----------------
???


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:1126
     }
 
+    // If there _is_ no new location, all we had to do was erase.
----------------
We don't use curly braces for single statements.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85771/new/

https://reviews.llvm.org/D85771