[PATCH] D85775: [DebugInstrRef][9/9] Handle DBG_INSTR_REFs use-before-defs in LiveDebugValues

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:1004
+  class UseBeforeDef {
+  public:
+    ValueIDNum ID;                 /// Value of this variable, def'd in block.
----------------
A class with all public members is called a struct ;-)


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:1005
+  public:
+    ValueIDNum ID;                 /// Value of this variable, def'd in block.
+    DebugVariable Var;             /// Identity of this variable.
----------------
It's either:
```
  /// Comment.
  int field;
```
or `int field; ///< Comment.` I prefer the first variant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85775/new/

https://reviews.llvm.org/D85775