[PATCH] D85627: [polly][cmake] Don't build LLVMPolly.so without PIC

Wed Aug 19 07:54:43 PDT 2020

ro marked an inline comment as done.
ro added a comment.

In D85627#2206550 <https://reviews.llvm.org/D85627#2206550>, @Meinersbur wrote:

> Could you outline your intended solution? If I read correctly, with `LLVM_ENABLE_PIC=OFF`, no Polly module will be built, making Polly useless unless Polly is built in-tree and `LLVM_POLLY_LINK_INTO_TOOLS` is used.

What do you mean by intended solution?  My intent was to avoid breaking the build with PIC code turned off.  Just as Windows doesn't support loadable modules and thus creation of `LLVMPolly.so` is disabled, it's just not possible to build a loadable module/shared object without PIC code, so there's no choice but to disable it.

================
Comment at: polly/lib/CMakeLists.txt:141
+if (MSVC OR NOT LLVM_ENABLE_PIC)
   # Add dummy target, because loadable modules are not supported on Windows
   add_custom_target(LLVMPolly)
----------------
Meinersbur wrote:
> Please update the comment
Done.  I've also tried to clarify the other comments.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85627/new/

https://reviews.llvm.org/D85627