[PATCH] D86166: sanitizer_common: Use void* for madvise first argument on Solaris.

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 06:57:28 PDT 2020


ro accepted this revision.
ro added a comment.
This revision is now accepted and ready to land.

Tested on `sparcv9-sun-solaris2.11` and `amd64-pc-solaris2.11` (both Solaris 11.4 and OpenIndiana).

It's quite a bit of verbiage for a snippet of code I'd rather restrict to Illumos only.  However, if this avoids breaking this a third time, it's a comment well spent.

LGTM, Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86166/new/

https://reviews.llvm.org/D86166



More information about the llvm-commits mailing list