[llvm] 71e0b82 - [InstCombine] Lower infinite combine loop detection thresholds

[Florian Hahn via llvm-commits]

This leads to an assertion failure when building MultiSource/Benchmarks/mafft from the test-suite on X86 with -O3 -flto.



> On Aug 19, 2020, at 12:38, Roman Lebedev via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> 
> Author: Roman Lebedev
> Date: 2020-08-19T14:37:57+03:00
> New Revision: 71e0b82c9f5039cb3987c91075e78733ef044c07
> 
> URL: https://github.com/llvm/llvm-project/commit/71e0b82c9f5039cb3987c91075e78733ef044c07
> DIFF: https://github.com/llvm/llvm-project/commit/71e0b82c9f5039cb3987c91075e78733ef044c07.diff
> 
> LOG: [InstCombine] Lower infinite combine loop detection thresholds
> 
> It's been a month since 2f3862eb9f21e8a0d48505637fefe6e5e295c18c,
> and no new bug reports about the threshold were filled,
> so let's bump it again and wait again.
> 
> Added: 
> 
> 
> Modified: 
>    llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
> 
> Removed: 
> 
> 
> 
> ################################################################################
> diff  --git a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
> index cb6e77aa029c..9033e084eb75 100644
> --- a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
> +++ b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
> @@ -127,7 +127,7 @@ DEBUG_COUNTER(VisitCounter, "instcombine-visit",
> // FIXME: these limits eventually should be as low as 2.
> static constexpr unsigned InstCombineDefaultMaxIterations = 1000;
> #ifndef NDEBUG
> -static constexpr unsigned InstCombineDefaultInfiniteLoopThreshold = 100;
> +static constexpr unsigned InstCombineDefaultInfiniteLoopThreshold = 10;
> #else
> static constexpr unsigned InstCombineDefaultInfiniteLoopThreshold = 1000;
> #endif
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits