[PATCH] D86213: [llvm-readobj] - Print "Unknown" when a program header is unknown.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 06:40:05 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
grimar requested review of this revision.

Currently, when a program header type is unknown, we dont print anything:

  ProgramHeader {
    Type:  (0x60000000)

With this patch the output will be:

  ProgramHeader {
    Type: Unknown (0x60000000)

It was discussed in D85526 <https://reviews.llvm.org/D85526> and consistent what we print for
'--sections' already, e.g.:

  Section {
    Name: .sec
    Type: Unknown (0x7FFFFFFF)
  }


https://reviews.llvm.org/D86213

Files:
  lld/test/ELF/linkerscript/non-alloc-segment.s
  lld/test/ELF/linkerscript/phdrs.s
  llvm/test/tools/llvm-readobj/ELF/program-headers.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86213.286549.patch
Type: text/x-patch
Size: 4786 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200819/18a1b51a/attachment.bin>


More information about the llvm-commits mailing list