[PATCH] D86200: [GlobalISel] Add setting of pointer flags to ArgInfo

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 06:32:06 PDT 2020


arsenm added a comment.
Herald added a subscriber: bjope.

I'm curious why you need this. These fields are mostly a hack for SelectionDAG?



================
Comment at: llvm/lib/CodeGen/GlobalISel/CallLowering.cpp:86-90
+  if (Arg.Ty->isPointerTy()) {
+    Flags.setPointer();
+    Flags.setPointerAddrSpace(
+        cast<PointerType>(Arg.Ty)->getAddressSpace());
+  }
----------------
dyn_cast instead of isPointerTy and cast?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86200/new/

https://reviews.llvm.org/D86200



More information about the llvm-commits mailing list