[PATCH] D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp

Wed Aug 19 02:09:33 PDT 2020

paulwalker-arm requested changes to this revision.
paulwalker-arm added a comment.
This revision now requires changes to proceed.

If the consensus is to accept sizeof(T)==1 then so be it, but personally it doesn't sit well with me.

================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64AddressingModes.h:769

   if (std::is_same<int16_t, std::make_signed_t<T>>::value)
     return IsImm8 || IsImm16 || uint16_t(Imm & ~0xff) == Imm;
----------------
jyknight wrote:
> sizeof(T) == 2 for consistency?
sizeof(float16_t) == 2, which nicely highlights why I don't like the sizeof approach.  If not already, someday somebody we'll want to support a 1 byte type that isn't an integer.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85225/new/

https://reviews.llvm.org/D85225