[PATCH] D86194: [DWARFYAML] Add support for emitting multiple abbrev tables.

Wed Aug 19 01:08:09 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:100
+  for (const DWARFYAML::AbbrevTable &AbbrevTable : DI.DebugAbbrev) {
+    for (auto AbbrevDecl : AbbrevTable.Table) {
+      AbbrevCode =
----------------
Don't use `auto` here. It's not obvious what the type is.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml:900
+
+## n) Test that yaml2obj emits an error message when a compilation unit has values but there is no associated abbrev tables.
+
----------------

================
Comment at: llvm/tools/obj2yaml/dwarf2yaml.cpp:26-43
+      DWARFYAML::AbbrevTable AbbrevTable;
       for (auto AbbrvDecl : AbbrvDeclSet.second) {
         DWARFYAML::Abbrev Abbrv;
         Abbrv.Code = AbbrvDecl.getCode();
         Abbrv.Tag = AbbrvDecl.getTag();
         Abbrv.Children = AbbrvDecl.hasChildren() ? dwarf::DW_CHILDREN_yes
                                                  : dwarf::DW_CHILDREN_no;
----------------
Does this work?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86194/new/

https://reviews.llvm.org/D86194