[PATCH] D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:301
+  _AUX_CSECT = 251,  ///< Identifies a csect auxiliary entry.
+  _AUX_SECT = 250    ///< Identifies a SECT auxiliary entry.
+};                   // 64-bit XCOFF file only.
----------------
jasonliu wrote:
> jhenderson wrote:
> > Not that it really matters, but it's more traiditional to order enums in ascending numerical order. Any particular reason you've done this in the reverse order?
> I sort of "copied" the list from the OS header, and that's just the order it appeared in OS header.
> I don't think it's particular important to have it in current order, I could change it to ascending order.
I haven't got any particular preference, so am happy to defer to whatever you prefer on this one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85774/new/

https://reviews.llvm.org/D85774