[PATCH] D83608: [NewPM][CodeGen] Introduce CodeGenPassBuilder to help build codegen pipeline

Tue Aug 18 15:35:10 PDT 2020

ychen added inline comments.

================
Comment at: llvm/include/llvm/CodeGen/CGPassBuilderOption.h:41-43
+  bool DisableLSR = false;
+  bool DisableCGP = false;
+  bool PrintLSR = false;
----------------
arsenm wrote:
> ychen wrote:
> > arsenm wrote:
> > > I think these need longer names and documentation comments
> > Sounds great. Comments added. I could do a followup patch for longer names. My intention was to make this close to a pure porting patch. WYDT? I don't mind put the renaming here though because they should be straightforward.
> It's not like it's sharing the actual code, so might as well improve over the old system
Thanks. Will do.

For pass disabling variables, how about prefixing the pass NPM name with `Disable` ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83608/new/

https://reviews.llvm.org/D83608