[PATCH] D84737: [AArch64][SVE] Preserve full vector regs over EH edge.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/RegAllocFast.cpp:1215
+      if (auto *RegMask = TRI->getCustomEHPadPreservedMask(*MBB.getParent()))
+        MRI->addPhysRegsUsedFromRegMask(RegMask);
+
----------------
This seems like a really weird location for this call; it's modifying function-global state in the middle of register allocation.

I'd prefer to do one of the following:

1. Attach the register mask to the landingpad instruction itself.
2. Update the function-global state when we construct the landing pad instruction/node.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84737/new/

https://reviews.llvm.org/D84737