[PATCH] D83313: [MachineOutliner] Fix liveness computing.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I guess there are three possible paths forward here:

1. Someone revives D40061 <https://reviews.llvm.org/D40061>, so it's impossible to have a terminator in the middle of a block.
2. We fix LiveRegUnits to handle this.
3. We accumulate technical debt by repeatedly fixing the same issue in every user of LiveRegUnits.

It should be obvious why (3) isn't appealing.

I don't see any problem with the logic in this patch, in the sense that the result of the analysis should correctly reflect reality.

If someone else wants to take over D40061 <https://reviews.llvm.org/D40061>, I'd be fine with that; I probably won't have time to work on it in the next few weeks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83313/new/

https://reviews.llvm.org/D83313