[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

Tue Aug 18 14:54:52 PDT 2020

craig.topper added inline comments.

================
Comment at: clang/test/Misc/target-invalid-cpu-note.c:49
+
+// RUN: not %clang_cc1 -triple x86_64--- -tune-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix TUNE_X86_64
+// TUNE_X86_64: error: unknown target CPU 'not-a-cpu'
----------------
efriedma wrote:
> Should we have a test for tune-cpu for some non-x86 target?  Or are we happy to just assume this works correctly because we already have coverage for target-cpu?
I copied the AARCH64 test above an added a -tune-cpu version of it. That will be included with my commit

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85384/new/

https://reviews.llvm.org/D85384