[PATCH] D85820: Use find_library for ncurses
Steven Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 18 14:42:22 PDT 2020
srj added inline comments.
================
Comment at: llvm/include/llvm/Config/config.h.cmake:212
/* Define if the setupterm() function is supported this platform. */
-#cmakedefine HAVE_TERMINFO ${HAVE_TERMINFO}
+#cmakedefine LLVM_ENABLE_TERMINFO ${LLVM_ENABLE_TERMINFO}
----------------
srj wrote:
> In my local build of LLVM, I end up with
>
> `#define LLVM_ENABLE_TERMINFO 1`
>
> in the generated `config.h` file, even thought I configured LLVM's CMake build with `-D LLVM_ENABLE_TERMINFO=OFF` -- surely this is a bug.
>
(fyi, prior to this commit, the corresponding line was `/* #undef HAVE_TERMINFO */`)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85820/new/
https://reviews.llvm.org/D85820
More information about the llvm-commits
mailing list