[PATCH] D86065: [SVE] Make ElementCount members private

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

> Perhaps now would be a good time to combine TypeSize and ElementCount into a single Polynomial type? We don't have to implement the whole abstraction of c*x^n (since we currently don't use the exponent, and don't distinguish between X's) but if it's ever needed in the future it will be obvious where to add it, and it will Just Work.

Even if the types are structurally similar, I'd prefer to keep them separate.  The uses are distinct, the usage in a function signature indicates what kind of value we actually expect.  (It's particularly easy to perform incorrect conversions with types representing size and alignment.)



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:3522
+          DAG.getNode(ISD::EXTRACT_SUBVECTOR, Dl,
+                      MemVT.getHalfNumVectorElementsVT(*DAG.getContext()),
+                      StoreNode->getValue(),
----------------
ctetreau wrote:
> What is this `>>` thing? Some indicator of whitespace change, or is this a hard tab?
It's an indicator of a whitespace change; I think they started showing up with the recent Phabricator upgrade


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86065/new/

https://reviews.llvm.org/D86065