[PATCH] D86134: Fix OCaml build failure because of absolute path in system libs
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 18 12:52:51 PDT 2020
phosek added inline comments.
================
Comment at: llvm/lib/Support/CMakeLists.txt:5
+function(get_system_libname OUTPUT LIBNAME)
+ get_filename_component(LIBNAME ${LIBNAME} NAME)
----------------
We typically use lowercase for function arguments, also the output variable usually goes at the end (unless the function has variable number of arguments).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86134/new/
https://reviews.llvm.org/D86134
More information about the llvm-commits
mailing list