[PATCH] D86120: [NFC][llvm] Make the contructors of `ElementCount` private.
Christopher Tetreault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 18 09:22:52 PDT 2020
ctetreau added inline comments.
================
Comment at: llvm/include/llvm/IR/Intrinsics.h:137
unsigned Argument_Info;
- ElementCount Vector_Width;
+ ElementCount Vector_Width = ElementCount::get(0, false);
};
----------------
use getFixed
================
Comment at: llvm/include/llvm/Support/TypeSize.h:30
+private:
ElementCount() = default;
----------------
since this is now private, and nothing uses it, it should be deleted
================
Comment at: llvm/lib/CodeGen/ValueTypes.cpp:52
EVT ResultVT;
- ResultVT.LLVMTy =
- VectorType::get(VT.getTypeForEVT(Context), {EC.Min, EC.Scalable});
+ ResultVT.LLVMTy = VectorType::get(VT.getTypeForEVT(Context),
+ ElementCount::get(EC.Min, EC.Scalable));
----------------
this can just pass the input ElementCount to VectorType::get
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86120/new/
https://reviews.llvm.org/D86120
More information about the llvm-commits
mailing list