[PATCH] D83034: [GlobalISel] Don't skip adding predicate matcher
Madhur Amilkanthwar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 18 08:38:01 PDT 2020
madhur13490 added inline comments.
================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:3665
+ InsnMatcher.addPredicate<AtomicOrderingMMOPredicateMatcher>("Monotonic");
+ return InsnMatcher;
+ }
----------------
arsenm wrote:
> How is changing this to return any different than continue? It's still treating all of these as mutually exclusive
It is returning to the parent createAndImportSelDAGMatcher which further adds custom predicate.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83034/new/
https://reviews.llvm.org/D83034
More information about the llvm-commits
mailing list