[PATCH] D86087: [ARM] Use mov operand if the mov cannot be moved while tail predicating

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 08:06:04 PDT 2020


samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM



================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:495
+          NumElements = TPNumElements.getReg();
+        } else {
+          LLVM_DEBUG(dbgs()
----------------
samtebbs wrote:
> samparker wrote:
> > Bit hard to tell on here, but it doesn't look like we can hit this block anymore.
> Could it not be hit if the if statement above fails?
yep! :) I need to learn to collapse comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86087/new/

https://reviews.llvm.org/D86087



More information about the llvm-commits mailing list