[PATCH] D86087: [ARM] Use mov operand if the mov cannot be moved while tail predicating

[Sam Tebbs via Phabricator via llvm-commits]

samtebbs added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:493
+                RDA.getUniqueReachingMIDef(StartInsertPt, Operand.getReg())) {
+          TPNumElements = Operand;
+          NumElements = TPNumElements.getReg();
----------------
samparker wrote:
> We don't need this variable, right?
TPNumElements? It's used in getLoopStartOperand (previously getCount).


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:495
+          NumElements = TPNumElements.getReg();
+        } else {
+          LLVM_DEBUG(dbgs()
----------------
samparker wrote:
> Bit hard to tell on here, but it doesn't look like we can hit this block anymore.
Could it not be hit if the if statement above fails?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86087/new/

https://reviews.llvm.org/D86087