[PATCH] D86087: [ARM] Use mov operand if the mov cannot be moved while tail predicating
Sam Parker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 18 07:07:51 PDT 2020
samparker added a comment.
> Sure, there is already a mov-after-dls mir test that I can add to.
Just generating a MIR file from mov-operand.ll would be fine and save you from manually having to alter an existing test.
================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:493
+ RDA.getUniqueReachingMIDef(StartInsertPt, Operand.getReg())) {
+ TPNumElements = Operand;
+ NumElements = TPNumElements.getReg();
----------------
We don't need this variable, right?
================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:495
+ NumElements = TPNumElements.getReg();
+ } else {
+ LLVM_DEBUG(dbgs()
----------------
Bit hard to tell on here, but it doesn't look like we can hit this block anymore.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86087/new/
https://reviews.llvm.org/D86087
More information about the llvm-commits
mailing list