[PATCH] D86138: [yaml2obj] - Don't crash when `FileHeader` declares an empty `Flags` key in specific situations.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 18 06:04:28 PDT 2020
grimar added a comment.
In D86138#2223614 <https://reviews.llvm.org/D86138#2223614>, @jhenderson wrote:
> LGTM. Is there testing for the other flags discussed in that function? If not, we might want to add it.
There is nothing yet, except the `mips-eflags.yaml` test for `obj2yaml` that does it for mips. Though I'd expect to see
a test for `yaml2obj` that uses something different, like `llvm-readobj`. So, yes, we might want to add more testing for all kind of `EF_*`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86138/new/
https://reviews.llvm.org/D86138
More information about the llvm-commits
mailing list