[PATCH] D86099: [AArch64][SVE] Fix calculation restore point for SVE callee saves.

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 04:18:25 PDT 2020


paulwalker-arm accepted this revision.
paulwalker-arm added a comment.
This revision is now accepted and ready to land.

Just a couple of typos to fix before landing the patch.



================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1697
   if (int64_t CalleeSavedSize = AFI->getSVECalleeSavedStackSize()) {
     RestoreBegin = std::prev(RestoreEnd);;
     while (IsSVECalleeSave(RestoreBegin) &&
----------------
Not due to this patch but since you're here can you remove the extra ";" please?


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1703
+    if (!IsSVECalleeSave(RestoreBegin))
+      ++RestoreBegin;
 
----------------
I'm guessing the rouge >> is a tab character that should be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86099/new/

https://reviews.llvm.org/D86099



More information about the llvm-commits mailing list