[PATCH] D85378: Fix off-by-one error in size of the required shadow memory passed to `MapDynamicShadow`.

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 03:09:42 PDT 2020


vitalybuka added a comment.

In D85378#2201220 <https://reviews.llvm.org/D85378#2201220>, @yln wrote:

> After looking at this again: would changing `MemToShadowSize()` to round-up to the closest multiple of page_size work?
> That would cover all platforms (since it's a shared function in asan_mapping.h).

If we rename the function.
As is I'd expect that MemToShadowSize returns minimal shadow size to cover argument, so round-up to shadow granularity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85378/new/

https://reviews.llvm.org/D85378



More information about the llvm-commits mailing list