[PATCH] D84519: [llvm-objdump][AMDGPU] Detect CPU string

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/Object/ELFObjectFile.cpp:382
+
+    // Radeon HD 4000 Series (R700).
+  case ELF::EF_AMDGPU_MACH_R600_RV710:
----------------
rochauha wrote:
> MaskRay wrote:
> > Why is the comment not aligned with `case `?
> This is the result after running clang-format.
Sounds like a clang-format bug that should be reported? I guess the problem is distinguishing comments for the case lines from those at the end of the previous case. Still, with the blank line before I think it's pretty clear that in this case the comment applies to the case.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/AMDGPU/subtarget.ll:5
+
+; Test subtarget detection. Disassembly is only supported for GFX8 and beyond.
+;
----------------
rochauha wrote:
> MaskRay wrote:
> > In these binary utility directories, we use `;; ` for non-RUN-non-CHECK comments. The different comment marker makes comments stand out.
> I looked at a few tests in the binary utility tests but didn't find this pattern. Do you suggest that this should be changed in this test?
A lot of the older tests were written before we adopted the double-comment marker style, and haven't been updated. Newer tests should be written with the new style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84519/new/

https://reviews.llvm.org/D84519