[PATCH] D86045: [llvm-dwarfdump] --statistics: switch to json::OStream. NFC

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added inline comments.


================
Comment at: llvm/tools/llvm-dwarfdump/Statistics.cpp:482
+      LocationStats[0]);
   LLVM_DEBUG(
       llvm::dbgs() << Key
----------------
jhenderson wrote:
> MaskRay wrote:
> > I am not sure repeating the message in LLVM_DEBUG is useful.
> > 
> > I can delete them in a separate change if people think the same as me.
> Not sure I've got any reasonable opinion here, since I don't really use this code or LLVM_DEBUG output ever. I'd prefer of one of the other typical users chime in here (e.g. @aprantl, @dblaikie, @Orlando)
I'm not sure how much weight my opinion carries here but I agree with removing the prints. I have never used these particular debug prints. When I want to inspect the output I usually just pipe it through `python -m json.tool` to format it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86045/new/

https://reviews.llvm.org/D86045