[PATCH] D85835: [llvm-readobj/elf] - Refine testing of broken Android's packed relocation sections.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 02:25:51 PDT 2020


grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/packed-relocs-errors.s:37
+.ascii "APS2"
+.sleb128 4 // Number of relocations
+.sleb128 0 // Initial offset
----------------
jhenderson wrote:
> MaskRay wrote:
> > You can unify the comment markers while updating the tests.
> I'm assuming this means '//' -> '##' for consistency. If so, +1 to that.
Oops. I missed this one. Will do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85835/new/

https://reviews.llvm.org/D85835



More information about the llvm-commits mailing list