[PATCH] D84822: Add documentation for target ID and ClangOffloadBundlerFormat

[Tony Tye via Phabricator via llvm-commits]

t-tye added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:227
+                                                                                       names.
+     ``gfx906``                  ``amdgcn``   dGPU  - sram-ecc                      - Radeon Instinct MI50
+                                                    - xnack                         - Radeon Instinct MI60
----------------
Change all occurences of sram-ecc to sramecc to avoid problems that hyphen is used as a bundled code object entry ID separator.


================
Comment at: llvm/docs/AMDGPUUsage.rst:2286
                                          for the definition of the mapping.
      ========== ============== ========= =======================================
 
----------------
Add "TargetID" attribute that is a string that is the target ID for the module.


================
Comment at: llvm/docs/AMDGPUUsage.rst:7677
 
 .amdgcn_target <target>
 +++++++++++++++++++++++
----------------
<target> -> <target-id>


================
Comment at: llvm/docs/AMDGPUUsage.rst:7680
 
 Optional directive which declares the target supported by the containing
 assembler source file. Valid values are described in
----------------
target ID


================
Comment at: llvm/docs/AMDGPUUsage.rst:7683-7684
 :ref:`amdgpu-amdhsa-code-object-target-identification`. Used by the assembler
 to validate command-line options such as ``-triple``, ``-mcpu``, and those
 which specify target features.
 
----------------
and ``-mcpu``.


================
Comment at: llvm/docs/AMDGPUUsage.rst:7760
                                                                                                :ref:`amdgpu-amdhsa-compute_pgm_rsrc1-gfx6-gfx10-table`.
      ``.amdhsa_reserve_xnack_mask``                           Target              GFX8-GFX10   Whether the kernel may trigger XNACK replay.
                                                               Feature                          Used to calculate GRANULATED_WAVEFRONT_SGPR_COUNT in
----------------
This directive is being removed since the information is now present in the target ID that is provided by the .amdgcn_target directive.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84822/new/

https://reviews.llvm.org/D84822