[PATCH] D82276: Make ninja smart console builds more pretty
Aaron Puchert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 17 17:36:18 PDT 2020
aaronpuchert added inline comments.
================
Comment at: llvm/cmake/modules/VersionFromVCS.cmake:49
+ else()
+ message(WARNING "Git not found. Version cannot be determined.")
endif()
----------------
Why a `WARNING` and not just a `STATUS`? When `git` can't be found the probability is high that this isn't a repo checkout but just a build from tarballs.
Alternatively we could try to detect if a `.git` directory is there and not warn if it isn't.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82276/new/
https://reviews.llvm.org/D82276
More information about the llvm-commits
mailing list