[PATCH] D85932: [UpdateTestChecks] Match 'attributes #' at the end

Mon Aug 17 17:32:02 PDT 2020

jdoerfert added inline comments.

================
Comment at: llvm/utils/UpdateTestChecks/common.py:320
+    NamelessValue(r'LOOP',  r'!llvm.loop !', r'',              r'[0-9]+?',   r''),
+    NamelessValue(r'META',  r'metadata !',   r'',              r'[0-9]+?',  r''),
 ]
----------------
sstefan1 wrote:
> jdoerfert wrote:
> > Nit: Align the columns. Maybe reorder so we have prefix and then regexp, we can then also make those a pair: `('r'%', r'...'), (...)`
> I am not sure I see a place where those could be used separately. Am I missing something?
I mean, it's easier to read the thing if the "local" prefixes are in a pair and then the global ones are. But it's just an idea, unclear if it's really easier to read at the end of the day.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85932/new/

https://reviews.llvm.org/D85932