[PATCH] D86005: [NewPM][LoopFullUnroll] Make LoopFullUnrollPass required

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D86005#2221998 <https://reviews.llvm.org/D86005#2221998>, @ychen wrote:

> This is to say optnone does not work for these 3 passes all the time. Could we do this in the optnone callback by checking the metadata of the branch inst in latch block? That is precisely what we meant here.

Do you mean don't have the optnone pass instrumentation say that the pass should be skipped if it sees the proper metadata? I think the metadata is specific just to this one pass and checking it doesn't belong in the optnone pass instrumentation.
There may be some semantic meaning to fully unrolling a loop, and that should happen regardless of optnone/opt-bisect, whatever else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86005/new/

https://reviews.llvm.org/D86005