[PATCH] D85965: [GlobalISel] Add a combine for ashr(shl x, c), c --> sext_inreg x, c'

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 16:53:41 PDT 2020


aemerson updated this revision to Diff 286175.
aemerson added a comment.
Herald added subscribers: kerbowa, nhaehnle, jvesely.

Use `isLegalOrBeforeLegalizer()` and make the combine run unconditionally as part of the "all" set. This causes codegen changes in AMDGPU.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85965/new/

https://reviews.llvm.org/D85965

Files:
  llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
  llvm/include/llvm/CodeGen/GlobalISel/MIPatternMatch.h
  llvm/include/llvm/Target/GlobalISel/Combine.td
  llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-ashr-shl-to-sext-inreg.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.sbfe.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.ubfe.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/sdiv.i64.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/srem.i64.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85965.286175.patch
Type: text/x-patch
Size: 16483 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200817/ae973c83/attachment-0001.bin>


More information about the llvm-commits mailing list