[PATCH] D85691: lld: link libatomic if needed for Timer

Josh Stone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 15:38:01 PDT 2020


cuviper added a comment.

> In D85691#2212015 <https://reviews.llvm.org/D85691#2212015>, @cuviper wrote:
>
>> Oh, when LLDB uses this flag, they have `LLDBStandalone.cmake` with `include(CheckAtomic)`.
>
> And you were observing this in an `lld` standalone build? Because otherwise we have `llvm/CMakeLists.txt` -> `llvm/cmake/config-ix.cmake` -> `llvm/cmake/modules/CheckAtomic.cmake`. So yeah, you should probably make sure this is included somehow.

Yeah, that was a standalone build. I did confirm the fix when I included that in Rust CI, but forgot to push it here, sorry.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85691/new/

https://reviews.llvm.org/D85691



More information about the llvm-commits mailing list