[PATCH] D85809: [LTO] Make setupLLVMOptimizationRemarks accept remarks hotness threshold

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Config.h:266
   int32_t splitStackAdjustSize;
+  unsigned optRemarksHotnessThreshold;
 
----------------
This should be moved above

```
  llvm::StringRef optRemarksFilename;
  llvm::StringRef optRemarksPasses;
  llvm::StringRef optRemarksFormat;
```


================
Comment at: lld/ELF/Options.td:546
+  "Minimum profile count required for an optimization remark to be output">,
+  MetaVarName<"<number>">;
 def opt_remarks_passes: Separate<["--"], "opt-remarks-passes">,
----------------
`<integer>` might be preciser.


================
Comment at: llvm/tools/gold/gold-plugin.cpp:302
+    } else if (opt.consume_front("opt-remarks-hotness-threshold=")) {
+      if (opt.getAsInteger(10, RemarksHotnessThreshold)) {
+        message(LDPL_FATAL, "Invalid remarks hotness threshold: %s", opt);
----------------
Drop unneeded inner braces


================
Comment at: llvm/tools/gold/gold-plugin.cpp:940
+  Conf.RemarksHotnessThreshold = options::RemarksHotnessThreshold;
+  ;
   Conf.RemarksFormat = options::RemarksFormat;
----------------
stray `;`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85809/new/

https://reviews.llvm.org/D85809